This repository has been archived by the owner on Aug 18, 2023. It is now read-only.
Mask environment configuration with no_log
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment files are frequently used to inject sensitive values to daemons. This change enables the no_log flag on this task. Alternatively, we could have two tasks that do the same thing and require users to opt out/in like such: ```yaml prometheus_my_exporter_env_vars: foo: 'not a secret, i like my diffs' prometheus_my_exporter_env_insensitive: true ```
|
Looks like some other exporters use configuration file based bits that pass credentials around. So I'm thinking this may need to be scoped out a bit more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this when I was configuring the mongo exporter, it requires me to set credentials via environment variables.
Environment files are frequently used to inject sensitive values to daemons; this change enables the
no_logflag on this task.Alternatively, we could have two tasks that do the same thing and require users to opt out/in perhaps something like this: